[Asset Inventory][Azure] Add storage asset fetchers #2938
Conversation
|
This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
|
…cloudbeat into asset-inventory-azure-storage
Co-authored-by: orouz <[email protected]>
…cloudbeat into asset-inventory-azure-storage
| @@ -109,15 +109,17 @@ Storage Bucket: 100% (1/1) | |||
|
|
|||
| ## AZURE Resources | |||
|
|
|||
| **Progress: 33% (18/54)** | |||
| **Progress: 42% (23/54)** | |||
| AssetClassificationAzureCosmosDBSQLDatabase = AssetClassification{CategoryInfrastructure, "Azure Cosmos DB SQL Database"} | ||
| AssetClassificationAzureDisk = AssetClassification{CategoryVolume, "Azure Disk"} | ||
| AssetClassificationAzureElasticPool = AssetClassification{CategoryDatabase, "Azure Elastic Pool"} | ||
| AssetClassificationAzureResourceGroup = AssetClassification{CategoryAccessManagement, "Azure Resource Group"} |
There was a problem hiding this comment.
sheet says the category for Azure Resource Group is Resource Group. IMO CategoryAccessManagement is a better fit, but just making sure this change is known?
There was a problem hiding this comment.
Pre-existing asset categories will be fixed in https://github.com/elastic/security-team/issues/11690
| AssetClassificationAzureStorageQueueService = AssetClassification{CategoryMessagingService, "Azure Storage Queue Service"} | ||
| AssetClassificationAzureStorageTable = AssetClassification{CategoryDatabase, "Azure Storage Table"} | ||
| AssetClassificationAzureStorageTableService = AssetClassification{CategoryServiceUsageTechnology, "Azure Storage Table Service"} | ||
| AssetClassificationAzureSubscription = AssetClassification{CategoryAccessManagement, "Azure Subscription"} |
There was a problem hiding this comment.
sheet says Azure Subscription category is Account
There was a problem hiding this comment.
Pre-existing asset categories will be fixed in https://github.com/elastic/security-team/issues/11690
| AssetClassificationAzureStorageTable = AssetClassification{CategoryDatabase, "Azure Storage Table"} | ||
| AssetClassificationAzureStorageTableService = AssetClassification{CategoryServiceUsageTechnology, "Azure Storage Table Service"} | ||
| AssetClassificationAzureSubscription = AssetClassification{CategoryAccessManagement, "Azure Subscription"} | ||
| AssetClassificationAzureTenant = AssetClassification{CategoryAccessManagement, "Azure Tenant"} |
There was a problem hiding this comment.
sheet says Azure Tenant category is Organization
There was a problem hiding this comment.
Pre-existing asset categories will be fixed in https://github.com/elastic/security-team/issues/11690
(cherry picked from commit 57ecd03) # Conflicts: # internal/inventory/ASSETS.md # internal/inventory/asset.go # internal/inventory/cloud_assets.xlsx # tests/product/tests/data/azure_asset_inventory/test_cases.py # tests/product/tests/test_aws_asset_inventory.py # tests/product/tests/test_azure_asset_inventory.py # tests/product/tests/test_gcp_asset_inventory.py
Summary of your changes
Introduces fetchers for:
Screenshot/Data
Related Issues
Closes https://github.com/elastic/security-team/issues/10172
Checklist